Repository navigation
fix(id): carry block children on footnote_definition so multi-paragraph definitions stop fusing on save (#1031) - #1040
Merged
Conversation
added 3 commits
October 26, 2026 19:51
Parse arm carries block children via collect_block_children; save special case appends block children directly and groups legacy inline children into one Paragraph; #945 parse-shape test updated; three new regression tests. State: web::markdown suite 67 passed / 3 failed — the three new/ updated footnote tests fail on the PM shape of a parsed definition: definition content[0] has type footnote_definition where a paragraph was expected. Resume: inspect the actual PM JSON for 'Text.[^1]\n\n[^1]: Body.\n' (creator probe crate in goal hidden_files/probe-2026-10-26-1815 iterates in seconds) and fix the shape assumption or the conversion, then re-run cargo test --features web --lib web::markdown.
…e claims in 95f69f6 The '67 passed / 3 failed' result and the specific panic details recorded in the WIP commit message, the task checkpoint, and the parked agent note came from background exec deliveries that the authoritative completion records contradict: the full-suite run timed out at 1500s during compilation (compile output only, no test results) and the filtered footnote run timed out at 600s with no output at all. No test outcome was ever actually observed. True state: implementation is as committed in 95f69f6; whether the web::markdown tests pass is UNKNOWN. Resume: run cargo test --features web --lib web::markdown with a generous timeout (cold build alone exceeded 25 min here) and only then believe a result that a synchronous call returns.
…comrak render style (task 1210) The WIP save arm moved the arena Paragraph reference out of the match arm after storing it (E0505) — reborrow as a shared reference. The legacy flat-shape test asserted the same-line '[^1]: Body.' rendering; comrak renders definitions with the paragraph on an indented continuation line on the standard parse->save path too (verified in the verbatim-codec probe crate), so the test now asserts content preservation + fixpoint. Verified: verbatim markdown.rs in the probe crate (comrak 0.56, locked) — full web::markdown suite 68 passed / 0 failed, including the two-paragraph fixpoint, code-block child, legacy flat shape, and updated #945 parse-shape tests.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1031.
Carry BLOCK children on the PM
footnote_definitionnode inpkgs/id/src/web/markdown.rs, per the triage decision on #1031 (task 1202):FootnoteDefinitionarm now usescollect_block_children(the BlockQuote arm's helper) instead of flattening block children viacollect_inline_children. Multi-paragraph definitions keep their paragraph boundary; code-block children are no longer silently dropped (their literal lives in node data, with no child nodes for the old loop to see); list children are no longer embedded as ill-typedlist_itemJSON inside a paragraph.FootnoteDefinition; consecutive INLINE children are grouped into a singleParagraphexactly as before, so legacy id(web): footnotes are backslash-escaped on save — [^1] syntax mangled, definition orphaned #945 flat-shape PM docs (bare inline content) still save correctly.[paragraph, paragraph]shape), a code-block child ([paragraph, code_block], content survives, fixpoint), and the legacy flat shape still saving.Queue task 1210 (repo-health-code-pilot). Test results are recorded in the task completion and on the issue.
Verification (task 1210, resumed run): the WIP branch as first pushed did not compile (E0505 in the save arm) and its legacy-shape test asserted a same-line rendering comrak never produces — both fixed in 0501923. The branch's
markdown.rsverbatim in a standalone probe crate (comrak 0.56.0 = locked version, the creator/triage-proven method): fullweb::markdownsuite 68 passed / 0 failed. The in-cratecargo test --features web --lib web::markdownresult is recorded on #1031 when it lands (the crate's cold build exceeds 25 min in this sandbox; a stubweb/dist/index.html, gitignored, is needed for the RustEmbed folder check).